From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 16/18] fs: Make iunique independent of inode_lock
Date: Fri, 8 Oct 2010 03:55:24 -0400
Message-ID: <20101008075524.GB30902@infradead.org>
References: <1286515292-15882-1-git-send-email-david@fromorbit.com>
 <1286515292-15882-17-git-send-email-david@fromorbit.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Dave Chinner <david@fromorbit.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1286515292-15882-17-git-send-email-david@fromorbit.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

> +	hlist_bl_for_each_entry(inode, node, &b->head, i_hash) {
> +		if (inode->i_ino == ino && inode->i_sb == sb) {

wouldn't it be more natural to test the sb first here?

Otherwise looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>