From: Christoph Hellwig <hch@infradead.org>
To: Dmitry Monakhov <dmonakhov@gmail.com>
Cc: jaxboe@fusionio.com, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] writeback: skip useless data integrity tricks for sync_filesystem
Date: Fri, 8 Oct 2010 13:09:31 -0400 [thread overview]
Message-ID: <20101008170931.GB23129@infradead.org> (raw)
In-Reply-To: <1286550027-9684-2-git-send-email-dmonakhov@gmail.com>
On Fri, Oct 08, 2010 at 07:00:27PM +0400, Dmitry Monakhov wrote:
> If we about to write many inodes at the time, even in for
> data integrity sync, it is reasonable to skip data integrity
> logic for each inode, but perform all necessary steps at the end.
>
> The frozen sync() issue:
> If we try to call sync() then other process dirties inodes in
> parallels we end up with writing inodes in sync mode, which
> usually result in io_barriers spam. Which result in almost 100 times
> performance degradation.
Please don't add even more flags for that. The only ->write_inode
call that actually needs this is the one from nfsd, and filesystems
can just implement the commit_metadata inode operation to force
out transactions there. That's what we've been doing in XFS for
a while now.
next prev parent reply other threads:[~2010-10-08 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 15:00 [PATCH 1/2] writeback: sync quota after inodes writeback Dmitry Monakhov
2010-10-08 15:00 ` [PATCH 2/2] writeback: skip useless data integrity tricks for sync_filesystem Dmitry Monakhov
2010-10-08 17:09 ` Christoph Hellwig [this message]
2010-10-08 17:08 ` [PATCH 1/2] writeback: sync quota after inodes writeback Christoph Hellwig
2010-10-20 12:25 ` Jan Kara
2010-10-20 15:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008170931.GB23129@infradead.org \
--to=hch@infradead.org \
--cc=dmonakhov@gmail.com \
--cc=jaxboe@fusionio.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).