From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH 14/18] fs: Protect inode->i_state with th einode->i_lock Date: Sat, 9 Oct 2010 08:52:27 -0600 Message-ID: <20101009145227.GE10421@parisc-linux.org> References: <1286515292-15882-1-git-send-email-david@fromorbit.com> <1286515292-15882-15-git-send-email-david@fromorbit.com> <20101008074932.GC24089@infradead.org> <20101008080428.GW4681@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Dave Chinner Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:35639 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753147Ab0JIOwa (ORCPT ); Sat, 9 Oct 2010 10:52:30 -0400 Content-Disposition: inline In-Reply-To: <20101008080428.GW4681@dastard> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Oct 08, 2010 at 07:04:28PM +1100, Dave Chinner wrote: > > > @@ -884,9 +897,9 @@ struct inode *new_inode(struct super_block *sb) > > > inode = alloc_inode(sb); > > > if (inode) { > > > spin_lock(&inode_lock); > > > - __inode_add_to_lists(sb, NULL, inode); > > > inode->i_ino = ++last_ino; > > > inode->i_state = 0; > > > + __inode_add_to_lists(sb, NULL, inode); > > > spin_unlock(&inode_lock); > > > } > > > return inode; > > > > What's the point in doing this move? > > hmmmm, let me think on that.... > > > > > > @@ -953,8 +966,8 @@ static struct inode *get_new_inode(struct super_block *sb, > > > if (set(inode, data)) > > > goto set_failed; > > > > > > - __inode_add_to_lists(sb, b, inode); > > > inode->i_state = I_NEW; > > > + __inode_add_to_lists(sb, b, inode); > > > > Same here. > > Ah, done thinking now! I was so the i_state field had been set > before the inode was added to various lists and potentially > accessable to other threads. I should probably add a comment to that > effect, right? If that can happen, don't we need a wmb() between the assignment to i_state and the list_add too? If so, that's a good comment :-) -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."