From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: [PATCH] security: move LSM xattrnames to xattr.h Date: Tue, 12 Oct 2010 09:19:11 -0400 Message-ID: <201010120919.11819.sgrubb@redhat.com> References: <1278011263-7951-1-git-send-email-zohar@linux.vnet.ibm.com> <201010121414.14486.ozan@pardus.org.tr> <1286888769.2670.5.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: Text/Plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Ozan =?utf-8?q?=C3=87a=C4=9Flayan?= , James Morris , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, Casey Schaufler , David Safford , Dave Hansen , Mimi Zohar To: Mimi Zohar Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19472 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754055Ab0JLNTm convert rfc822-to-8bit (ORCPT ); Tue, 12 Oct 2010 09:19:42 -0400 In-Reply-To: <1286888769.2670.5.camel@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tuesday, October 12, 2010 09:06:09 am Mimi Zohar wrote: > On Tue, 2010-10-12 at 14:14 +0300, Ozan =C3=87a=C4=9Flayan wrote: > > Cuma 02 Temmuz 2010 g=C3=BCn=C3=BC (saat 03:16:01) James Morris =C5= =9Funlar=C4=B1 yazm=C4=B1=C5=9Ft=C4=B1: > > > On Thu, 1 Jul 2010, Mimi Zohar wrote: > > > > Make the security extended attributes names global. Updated to = move > > > > the remaining Smack xattrs. > > > >=20 > > > > Signed-off-by: Mimi Zohar > > > > Acked-by: Serge Hallyn > >=20 > > This drops > >=20 > > #define XATTR_CAPS_SUFFIX "capability" > > #define XATTR_NAME_CAPS XATTR_SECURITY_PREFIX XATTR_CAPS_SUFFIX > >=20 > > definitions from capability.h and puts them in xattr.h's #ifdef > > __KERNEL__ section making them invisible to userspace like libcap-n= g > > causing build failures. > >=20 > > Am I wrong? >=20 > You're correct. It's the same reason that cap-ng.c has to define > 'security'. >=20 > #ifdef VFS_CAP_U32 > #include > #define XATTR_SECURITY_PREFIX "security." >=20 > Am cc'ing Steve. So does this mean I need to provide more definitions for libcap-ng to w= ork with=20 future kernels or are you asking my opinion? My opinion is that if user= space=20 needs it to work correctly, please let it be available so I don't have = to make=20 my own define which may be inaccurate one day. Thanks, -Steve -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html