From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 04/18] fs: inode split IO and LRU lists Date: Wed, 13 Oct 2010 07:31:22 -0400 Message-ID: <20101013113122.GA19456@infradead.org> References: <1286928961-15157-1-git-send-email-david@fromorbit.com> <1286928961-15157-5-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Dave Chinner Return-path: Received: from canuck.infradead.org ([134.117.69.58]:47299 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753566Ab0JMLbX (ORCPT ); Wed, 13 Oct 2010 07:31:23 -0400 Content-Disposition: inline In-Reply-To: <1286928961-15157-5-git-send-email-david@fromorbit.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Oct 13, 2010 at 11:15:47AM +1100, Dave Chinner wrote: > From: Nick Piggin > > The use of the same inode list structure (inode->i_list) for two > different list constructs with different lifecycles and purposes > makes it impossible to separate the locking of the different > operations. Therefore, to enable the separation of the locking of > the writeback and reclaim lists, split the inode->i_list into two > separate lists dedicated to their specific tracking functions. looks good, Reviewed-by: Christoph Hellwig