From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 05/18] fs: Clean up inode reference counting Date: Wed, 13 Oct 2010 07:33:20 -0400 Message-ID: <20101013113320.GB19456@infradead.org> References: <1286928961-15157-1-git-send-email-david@fromorbit.com> <1286928961-15157-6-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Dave Chinner Return-path: Content-Disposition: inline In-Reply-To: <1286928961-15157-6-git-send-email-david@fromorbit.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Oct 13, 2010 at 11:15:48AM +1100, Dave Chinner wrote: > From: Dave Chinner > > Lots of filesystem code open codes the act of getting a reference to > an inode. Factor the open coded inode lock, increment, unlock into > a function iref(). This removes most direct external references to > the inode reference count. Looks good, Reviewed-by: Christoph Hellwig