From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 06/18] exofs: use iput() for inode reference count decrements Date: Wed, 13 Oct 2010 07:34:02 -0400 Message-ID: <20101013113402.GC19456@infradead.org> References: <1286928961-15157-1-git-send-email-david@fromorbit.com> <1286928961-15157-7-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Dave Chinner Return-path: Received: from canuck.infradead.org ([134.117.69.58]:47365 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753816Ab0JMLeC (ORCPT ); Wed, 13 Oct 2010 07:34:02 -0400 Content-Disposition: inline In-Reply-To: <1286928961-15157-7-git-send-email-david@fromorbit.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Btw, this looks like a nasty enough bug that it might be worth queing up for 2.6.36. On Wed, Oct 13, 2010 at 11:15:49AM +1100, Dave Chinner wrote: > From: Dave Chinner > > Direct modification of the inode reference count is a no-no. Convert > the exofs decrements to call iput() instead of acting directly on > i_count. > > Signed-off-by: Dave Chinner > Reviewed-by: Christoph Hellwig > --- > fs/exofs/inode.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c > index b631ff3..0fb4d4c 100644 > --- a/fs/exofs/inode.c > +++ b/fs/exofs/inode.c > @@ -1101,7 +1101,7 @@ static void create_done(struct exofs_io_state *ios, void *p) > > set_obj_created(oi); > > - atomic_dec(&inode->i_count); > + iput(inode); > wake_up(&oi->i_wq); > } > > @@ -1161,7 +1161,7 @@ struct inode *exofs_new_inode(struct inode *dir, int mode) > ios->cred = oi->i_cred; > ret = exofs_sbi_create(ios); > if (ret) { > - atomic_dec(&inode->i_count); > + iput(inode); > exofs_put_io_state(ios); > return ERR_PTR(ret); > } > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ---end quoted text---