From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 17/18] fs: split __inode_add_to_list Date: Wed, 13 Oct 2010 11:08:17 -0400 Message-ID: <20101013150817.GB12757@infradead.org> References: <1286928961-15157-1-git-send-email-david@fromorbit.com> <1286928961-15157-18-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Dave Chinner Return-path: Received: from canuck.infradead.org ([134.117.69.58]:48305 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199Ab0JMPIS (ORCPT ); Wed, 13 Oct 2010 11:08:18 -0400 Content-Disposition: inline In-Reply-To: <1286928961-15157-18-git-send-email-david@fromorbit.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > > if (!list_empty(&inode->i_sb_list)) { > - spin_lock(&inode->i_sb->s_inodes_lock); > - list_del_init(&inode->i_sb_list); > - spin_unlock(&inode->i_sb->s_inodes_lock); > + inode_sb_list_del(inode); > } no need to keep the braces here.