From: Christoph Hellwig <hch@infradead.org>
To: Eric Paris <eparis@redhat.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: fsnotify_unmount_inodes
Date: Fri, 15 Oct 2010 14:02:23 -0400 [thread overview]
Message-ID: <20101015180223.GA6970@infradead.org> (raw)
Hi Eric,
I just stumbled over fsnotify_unmount_inodes when auditing some
inode list code. For one thing the idea to walk the whole inode list
when we already do this again just later seems odd. Did you consider
having a per-inode call from invalidate_list instead? That would also
help to get rid of the rather messy refcount games.
Second it sends a FS_UNMOUNT notification. But only one of the callers
actually is for umount. Arguably the other calls are rather obscure
(weird ioctl, cluster filesystems, etc), but the name suggests that
the users might not be prepared for it. And even the the umount we
talk about here is the final reference count drop of the superblock,
not the detachment from namespace - I can't really see how an
application can use this notification in a meaningful way.
reply other threads:[~2010-10-15 18:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015180223.GA6970@infradead.org \
--to=hch@infradead.org \
--cc=eparis@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).