* fsnotify_unmount_inodes
@ 2010-10-15 18:02 Christoph Hellwig
0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2010-10-15 18:02 UTC (permalink / raw)
To: Eric Paris; +Cc: linux-fsdevel
Hi Eric,
I just stumbled over fsnotify_unmount_inodes when auditing some
inode list code. For one thing the idea to walk the whole inode list
when we already do this again just later seems odd. Did you consider
having a per-inode call from invalidate_list instead? That would also
help to get rid of the rather messy refcount games.
Second it sends a FS_UNMOUNT notification. But only one of the callers
actually is for umount. Arguably the other calls are rather obscure
(weird ioctl, cluster filesystems, etc), but the name suggests that
the users might not be prepared for it. And even the the umount we
talk about here is the final reference count drop of the superblock,
not the detachment from namespace - I can't really see how an
application can use this notification in a meaningful way.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-10-15 18:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-15 18:02 fsnotify_unmount_inodes Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).