From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Piggin <npiggin@kernel.dk>
Subject: Re: [PATCH 15/18] fs: introduce a per-cpu last_ino allocator
Date: Sat, 16 Oct 2010 18:57:21 +1100
Message-ID: <20101016075721.GS19147@amd>
References: <1286515292-15882-1-git-send-email-david@fromorbit.com>
 <1286515292-15882-16-git-send-email-david@fromorbit.com>
 <20101008095658.GA19804@ZenIV.linux.org.uk>
 <20101008100346.GA27737@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	Dave Chinner <david@fromorbit.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:41874 "EHLO
	ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753440Ab0JPH52 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 16 Oct 2010 03:57:28 -0400
Content-Disposition: inline
In-Reply-To: <20101008100346.GA27737@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Oct 08, 2010 at 06:03:46AM -0400, Christoph Hellwig wrote:
> On Fri, Oct 08, 2010 at 10:56:58AM +0100, Al Viro wrote:
> > FWIW, that one is begging to be split; what I mean is that there are
> > two classes of callers; ones that will set i_ino themselves anyway
> > and ones that really want i_ino invented.  Two functions?
> 
> There's no reason to add i_ino before adding it to the per-sb list,
> we don't do so either for inodes acquired via iget.  The fix is simply
> to stop assigning i_ino in new_inode and call the helper to get it in
> the place that need it after the call to new_inode.  Later we can

My approach in my tree is a new function like Al suggests, which
simply doesn't assign the ino. That keeps compatibility backward.