From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [PATCH 03/17] fs: icache lock inode hash Date: Sat, 16 Oct 2010 18:57:43 +1100 Message-ID: <20101016075743.GU19147@amd> References: <1285762729-17928-1-git-send-email-david@fromorbit.com> <1285762729-17928-4-git-send-email-david@fromorbit.com> <20101001060650.GH32349@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Dave Chinner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Christoph Hellwig Return-path: Content-Disposition: inline In-Reply-To: <20101001060650.GH32349@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Oct 01, 2010 at 02:06:50AM -0400, Christoph Hellwig wrote: > On Wed, Sep 29, 2010 at 10:18:35PM +1000, Dave Chinner wrote: > > From: Nick Piggin > > > > Currently the inode hash lists are protected by the inode_lock. To > > allow removal of the inode_lock, we need to protect the inode hash > > table lists with a new lock. Nest the new inode_hash_lock inside the > > inode_lock to protect the hash lists. > > There is no reason to make inode_hash_lock global, it's only used inside > inode.c It was like that while hugetlbfs still used it. Fixed, thanks.