From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 01/19] fs: switch bdev inode bdi's correctly Date: Sat, 16 Oct 2010 12:31:16 -0400 Message-ID: <20101016163116.GD20086@infradead.org> References: <1287216853-17634-1-git-send-email-david@fromorbit.com> <1287216853-17634-2-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Dave Chinner Return-path: Received: from canuck.infradead.org ([134.117.69.58]:55165 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663Ab0JPQbR (ORCPT ); Sat, 16 Oct 2010 12:31:17 -0400 Content-Disposition: inline In-Reply-To: <1287216853-17634-2-git-send-email-david@fromorbit.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Oct 16, 2010 at 07:13:55PM +1100, Dave Chinner wrote: > From: Dave Chinner > > bdev inodes can remain dirty even after their last close. Hence the > BDI associated with the bdev->inode gets modified duringthe last > close to point to the default BDI. However, the bdev inode still > needs to be moved to the dirty lists of the new BDI, otherwise it > will corrupt the writeback list is was left on. > > Add a new function bdev_inode_switch_bdi() to move all the bdi state > from the old bdi to the new one safely. This is only a temporary > measure until the bdev inode<->bdi lifecycle problems are sorted > out. Ok for now, I really hope my progress on sorting out the bdi mess will eventually get rid of this. Reviewed-by: Christoph Hellwig