From: Christoph Hellwig <hch@infradead.org>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kenel.org,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, hch@infradead.org,
zohar@us.ibm.com, warthog9@kernel.org, david@fromorbit.com,
jmorris@namei.org, kyle@mcmartin.ca, hpa@zytor.com,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
mingo@elte.hu, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 1/3] IMA: move read/write counters into struct inode
Date: Mon, 18 Oct 2010 21:30:38 -0400 [thread overview]
Message-ID: <20101019013037.GA31393@infradead.org> (raw)
In-Reply-To: <20101019011650.25346.99614.stgit@paris.rdu.redhat.com>
I do not like this at all. It bloats the inode with three unsigned
long values for a feature no sane person would ever use. And given
that distros are sweet-talked by IBM to enable it the world will pay
a huge penality for those 0.5% of the userbase that use IMA.
Please reorder your series to have patch to disable IMA unless
explicitly enabled on the kernel command line first, and then second
use the rbtree from your last patch.
next prev parent reply other threads:[~2010-10-19 1:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 1:16 [PATCH 1/3] IMA: move read/write counters into struct inode Eric Paris
2010-10-19 1:16 ` [PATCH 2/3] IMA: only allocate iint when needed Eric Paris
2010-10-19 1:17 ` [PATCH 3/3] IMA: use rbtree instead of radix tree for inode information cache Eric Paris
2010-10-19 1:30 ` Christoph Hellwig [this message]
2010-10-19 2:14 ` [PATCH 1/3] IMA: move read/write counters into struct inode Eric Paris
2010-10-19 7:39 ` Dave Chinner
2010-10-19 16:24 ` Eric Paris
2010-10-19 16:29 ` Christoph Hellwig
2010-10-19 8:39 ` Ingo Molnar
2010-10-19 2:46 ` Eric Paris
2010-10-19 15:52 ` Linus Torvalds
2010-10-19 16:36 ` Eric Paris
2010-10-19 16:55 ` Al Viro
2010-10-19 17:03 ` Linus Torvalds
2010-10-19 17:28 ` Al Viro
2010-10-19 18:16 ` Mimi Zohar
2010-10-20 13:10 ` John Stoffel
2010-10-20 13:36 ` Al Viro
2010-10-20 14:09 ` John Stoffel
2010-10-19 19:11 ` Matthew Wilcox
2010-10-20 3:15 ` Al Viro
2010-10-20 17:38 ` J. Bruce Fields
2010-10-19 22:49 ` Eric Paris
2010-10-20 14:38 ` Ingo Molnar
2010-10-20 14:46 ` Eric Paris
2010-10-20 15:15 ` Ingo Molnar
2010-10-20 15:25 ` Eric Paris
2010-10-21 16:15 ` Casey Schaufler
2010-10-22 8:48 ` Ingo Molnar
2010-10-22 17:50 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019013037.GA31393@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=eparis@redhat.com \
--cc=hpa@zytor.com \
--cc=jmorris@namei.org \
--cc=kyle@mcmartin.ca \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kenel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=warthog9@kernel.org \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).