From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dmitry Monakhov <dmonakhov@gmail.com>,
jaxboe@fusionio.com, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] writeback: sync quota after inodes writeback
Date: Wed, 20 Oct 2010 14:25:52 +0200 [thread overview]
Message-ID: <20101020122552.GB3335@quack.suse.cz> (raw)
In-Reply-To: <20101008170806.GA23129@infradead.org>
On Fri 08-10-10 13:08:06, Christoph Hellwig wrote:
> On Fri, Oct 08, 2010 at 07:00:26PM +0400, Dmitry Monakhov wrote:
> > inode writeback usually result in quota changes especially
> > on filesystems with delalloc. So quota_sync() before writeback
> > seems pointless. Let's do the job in a natural way.
>
> Yes, that's one reason why we can't use the quota sync callback for XFS,
> as we need to do it after the actual sync. Then again I'm not even
> sure we need to bother with a callout from the writeback code.
> Following the model of all other quota code filesystems using quota
> should probably just call it from their ->sync_fs method. Note that
> this allows allows other optimizations for using the generic quota
> code. dquot_quota_sync currently calls ->sync_fs by itself which
> could be optimized away by that design.
Yes, that would make sense but then we have to change quotactl(Q_SYNC,
...) to result in calling ->sync_fs() as it does now. Because we have
to get quota data to disk in response to this call.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-10-20 12:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 15:00 [PATCH 1/2] writeback: sync quota after inodes writeback Dmitry Monakhov
2010-10-08 15:00 ` [PATCH 2/2] writeback: skip useless data integrity tricks for sync_filesystem Dmitry Monakhov
2010-10-08 17:09 ` Christoph Hellwig
2010-10-08 17:08 ` [PATCH 1/2] writeback: sync quota after inodes writeback Christoph Hellwig
2010-10-20 12:25 ` Jan Kara [this message]
2010-10-20 15:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020122552.GB3335@quack.suse.cz \
--to=jack@suse.cz \
--cc=dmonakhov@gmail.com \
--cc=hch@infradead.org \
--cc=jaxboe@fusionio.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).