From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Kaiser Subject: [PATCH] fs: return error on error condition Date: Wed, 20 Oct 2010 16:50:47 +0200 Message-ID: <20101020165047.09150171@absol.kitzblitz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Alexander Viro Return-path: Received: from webhosting01.bon.m2soft.com ([195.38.20.32]:34669 "EHLO webhosting01.bon.m2soft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725Ab0JTOzT (ORCPT ); Wed, 20 Oct 2010 10:55:19 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: It's intended to return an error, right? Signed-off-by: Nicolas Kaiser --- fs/pipe.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/pipe.c b/fs/pipe.c index 279eef9..37eb1eb 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -382,7 +382,7 @@ pipe_read(struct kiocb *iocb, const struct iovec *_iov, error = ops->confirm(pipe, buf); if (error) { if (!ret) - error = ret; + ret = error; break; } -- 1.7.2.2