From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH] mm: Fix comment at truncate_setsize() Date: Thu, 21 Oct 2010 17:30:00 +0200 Message-ID: <20101021153000.GA9732@quack.suse.cz> References: <1287654442-5539-1-git-send-email-jack@suse.cz> <20101021114812.GB19804@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="ZGiS0Q5IWpPtfppv" Cc: Jan Kara , linux-fsdevel@vger.kernel.org, Christoph Hellwig To: Al Viro Return-path: Received: from cantor.suse.de ([195.135.220.2]:42728 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753192Ab0JUPbC (ORCPT ); Thu, 21 Oct 2010 11:31:02 -0400 Content-Disposition: inline In-Reply-To: <20101021114812.GB19804@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu 21-10-10 12:48:12, Al Viro wrote: > On Thu, Oct 21, 2010 at 11:47:22AM +0200, Jan Kara wrote: > > The main fix in this patch is that truncate_setsize() should be called > > *before* not after filesystem truncated blocks. > > ITYM "contrary to what comment says, ..."; as it is, commit message alone > reads as if commit fixed the problem with actual code. OK. Attached is a version with updated changelog. Is it better? Honza --ZGiS0Q5IWpPtfppv Content-Type: text/x-patch; charset=us-ascii Content-Disposition: attachment; filename="0001-mm-Fix-comment-at-truncate_setsize.patch" >>From f237e25cae0b628fc81e4fa69b3b2a2ab2d0b086 Mon Sep 17 00:00:00 2001 From: Jan Kara Date: Thu, 21 Oct 2010 11:29:09 +0200 Subject: [PATCH] mm: Fix comment at truncate_setsize() The main fix in this patch is that, contrary to what the comment says, truncate_setsize() should be called *before* filesystem truncated blocks. CC: Christoph Hellwig Signed-off-by: Jan Kara --- mm/truncate.c | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/mm/truncate.c b/mm/truncate.c index ba887bf..e13e535 100644 --- a/mm/truncate.c +++ b/mm/truncate.c @@ -545,13 +545,12 @@ EXPORT_SYMBOL(truncate_pagecache); * @inode: inode * @newsize: new file size * - * truncate_setsize updastes i_size update and performs pagecache - * truncation (if necessary) for a file size updates. It will be - * typically be called from the filesystem's setattr function when - * ATTR_SIZE is passed in. + * truncate_setsize updates i_size and performs pagecache truncation (if + * necessary) to @newsize. It will be typically be called from the filesystem's + * setattr function when ATTR_SIZE is passed in. * - * Must be called with inode_mutex held and after all filesystem - * specific block truncation has been performed. + * Must be called with inode_mutex held and before all filesystem specific + * block truncation has been performed. */ void truncate_setsize(struct inode *inode, loff_t newsize) { -- 1.6.4.2 --ZGiS0Q5IWpPtfppv--