From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 1/4] fs: do not drop inode_lock in dispose_list Date: Mon, 25 Oct 2010 16:33:53 +1100 Message-ID: <20101025053353.GA16131@dastard> References: <20101024174024.GA2718@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from bld-mail19.adl2.internode.on.net ([150.101.137.104]:33428 "EHLO mail.internode.on.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751680Ab0JYFeY (ORCPT ); Mon, 25 Oct 2010 01:34:24 -0400 Content-Disposition: inline In-Reply-To: <20101024174024.GA2718@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Oct 24, 2010 at 07:40:24PM +0200, Christoph Hellwig wrote: > > Despite the comment above it we can not safely drop the lock here. > invalidate_list is called from many other places that just umount. > Also switch to proper list macros now that we never drop the lock. > > Signed-off-by: Christoph Hellwig What tree are these patches against - a couple of them don't quite apply to Al's merge-stem tree... Cheers, Dave. -- Dave Chinner david@fromorbit.com