From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2/4] fs: factor inode disposal
Date: Wed, 27 Oct 2010 05:06:43 -0400
Message-ID: <20101027090643.GC16443@infradead.org>
References: <1288153384-8878-1-git-send-email-david@fromorbit.com>
 <1288153384-8878-3-git-send-email-david@fromorbit.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Dave Chinner <david@fromorbit.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1288153384-8878-3-git-send-email-david@fromorbit.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

> +	if (!drop && (sb->s_flags & MS_ACTIVE)) {
> +		inode->i_state |= I_REFERENCED;
> +		if (!(inode->i_state & (I_DIRTY|I_SYNC)))
> +			inode_lru_list_add(inode);
> +		spin_unlock(&inode->i_lock);
> +		spin_unlock(&inode_lock);
> +		return;
> +	}
> +
>  	if (!drop) {
> -		if (sb->s_flags & MS_ACTIVE) {
> -			inode->i_state |= I_REFERENCED;
> -			if (!(inode->i_state & (I_DIRTY|I_SYNC))) {
> -				inode_lru_list_add(inode);
> -			}
> -			spin_unlock(&inode->i_lock);
> -			spin_unlock(&inode_lock);
> -			return;
> -		}

Btw, I'm really not sure what this change buys us.