From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 4/4] fs: remove inode_lock from iput_final and prune_icache Date: Wed, 27 Oct 2010 20:12:52 +1100 Message-ID: <20101027091252.GE32255@dastard> References: <1288153384-8878-1-git-send-email-david@fromorbit.com> <1288153384-8878-5-git-send-email-david@fromorbit.com> <20101027044038.GE19804@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Al Viro Return-path: Received: from bld-mail15.adl6.internode.on.net ([150.101.137.100]:50623 "EHLO mail.internode.on.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751016Ab0J0JM4 (ORCPT ); Wed, 27 Oct 2010 05:12:56 -0400 Content-Disposition: inline In-Reply-To: <20101027044038.GE19804@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Oct 27, 2010 at 05:40:38AM +0100, Al Viro wrote: > On Wed, Oct 27, 2010 at 03:23:04PM +1100, Dave Chinner wrote: > > From: Dave Chinner > >=20 > > Now that inode state changes are protected by the inode->i_lock and > > the inode LRU manipulations by the inode_lru_lock, we can remove th= e > > inode_lock from prune_icache and the initial part of iput_final(). > >=20 > > instead of using the inode_lock to protect the inode during > > iput_final, use the inode->i_lock instead. This protects the inode > > against new references being taken while we change the inode state > > to I_FREEING, as well as preventing prune_icache from grabbing the > > inode while we are manipulating it. Hence we no longer need the > > i???ode_lock in iput_final prior to setting I_FREEING on the inode. > ^^^^^^^^^^^^ >=20 > ... the hell? There's more such damage elsewhere in the thread; what= 's > going on? vim utf-8 multibyte support that is causing these characters to be created. e.g. e' results in =E9. sometimes the resultant character looks almost identical and so I didn't notice. I haven't found the magic recipe to turn this off (maxcombine=3D0 doesn't seem to stop it) or change the special compose sequence, so I'll keep looking. Cheers, Dave. --=20 Dave Chinner david@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html