From: Christoph Hellwig <hch@infradead.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Lukas Czerner <lczerner@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: fs: Add FITRIM ioctl
Date: Thu, 28 Oct 2010 07:25:38 -0400 [thread overview]
Message-ID: <20101028112538.GA16435@infradead.org> (raw)
In-Reply-To: <4CC950D5.8000603@panasas.com>
On Thu, Oct 28, 2010 at 12:30:45PM +0200, Boaz Harrosh wrote:
> I've just noticed this patch. Was it posted to linux-fsdevel? Sorry
> for missing it.
It has been, but only very recently.
I can't say I overly like it. There's no real point in dispatching this
out to a separate vector instead of just through ->ioctl. It's got
rather useless special case for ommiting the argument, and the whole
thing just doesn't seem generic enough to do it in the VFS.
Why did this common code go in through the ext4 tree as a start, and
without hitting linux-next before the merge window?
> What is the point of that? sb->s_bdev is not used anywhere in this code.
> If an FS published an sb->s_op->trim_fs, it should know what it wants
> No? Note that the FS in question does not even need to check. It already
> knows if it's block based or not.
Indeed. Looks like copied from freeze/thaw which used to be block
device based, but don't really need this anymore either.
next prev parent reply other threads:[~2010-10-28 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 10:30 fs: Add FITRIM ioctl Boaz Harrosh
2010-10-28 11:25 ` Christoph Hellwig [this message]
2010-10-29 9:50 ` Lukas Czerner
2010-10-29 8:58 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028112538.GA16435@infradead.org \
--to=hch@infradead.org \
--cc=bharrosh@panasas.com \
--cc=lczerner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).