From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] fs: move i_hash out from under inode_lock
Date: Thu, 28 Oct 2010 10:24:14 -0400 [thread overview]
Message-ID: <20101028142414.GA28390@infradead.org> (raw)
In-Reply-To: <1288266161-28897-4-git-send-email-david@fromorbit.com>
> @@ -925,8 +934,8 @@ static struct inode *get_new_inode(struct super_block *sb,
> inode->i_state = I_NEW;
> spin_unlock(&inode->i_lock);
> hlist_add_head(&inode->i_hash, head);
> + spin_unlock(&inode_hash_lock);
> inode_sb_list_add(inode);
> - spin_unlock(&inode_lock);
Al said he wanted to have the sb lock nest inside the hash lock for now
I think. Doubt it matters much, but it keeps the behaviour that we
can't look up an inode which is not added to the per-sb list yet.
After that a better patch description might be:
"rename inode_lock to inode_hash_lock"
as the inode_lock coverage after the previous patches should be 100%
identical to the new hash lock.
next prev parent reply other threads:[~2010-10-28 14:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 11:42 [PATCH 0/3] fs: peel back the inode_lock some more Dave Chinner
2010-10-28 11:42 ` [PATCH 1/3] fs: move i_sb_list out from under inode_lock Dave Chinner
2010-10-28 14:11 ` Christoph Hellwig
2010-10-28 11:42 ` [PATCH 2/3] fs: move i_wb_list " Dave Chinner
2010-10-28 14:19 ` Christoph Hellwig
2010-10-28 21:47 ` Dave Chinner
2010-10-28 11:42 ` [PATCH 3/3] fs: move i_hash " Dave Chinner
2010-10-28 14:24 ` Christoph Hellwig [this message]
2010-10-28 12:00 ` [PATCH 0/3] fs: peel back the inode_lock some more Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028142414.GA28390@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).