From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: fix possible use after free in finish_open()
Date: Fri, 29 Oct 2010 07:58:19 +0100 [thread overview]
Message-ID: <20101029065819.GQ19804@ZenIV.linux.org.uk> (raw)
In-Reply-To: <E1PAgls-00049P-QS@pomaz-ex.szeredi.hu>
On Tue, Oct 26, 2010 at 12:28:48PM +0200, Miklos Szeredi wrote:
> Oops, broken patch. Here's the correct one.
>
> ----
> Subject: vfs: fix possible use after free in finish_open()
>
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> In finish_open() nd->path is used after nameidata_to_filp() already
> released it. Fix by acquiring a ref to nd->path and releasing after
> the last use.
Nice catch, but I'd do it differently; that is, do not drop reference
in nameidata_to_filp() (and dup it if we do __dentry_open()) and drop
it in callers instead. Will push in a few.
prev parent reply other threads:[~2010-10-29 6:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 13:16 [PATCH] vfs: fix possible use after free in finish_open() Miklos Szeredi
2010-10-26 10:28 ` Miklos Szeredi
2010-10-29 6:58 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101029065819.GQ19804@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).