From mboxrd@z Thu Jan 1 00:00:00 1970 From: Edward Shishkin Subject: [PATCH] ecryptfs: fix truncation error in ecryptfs_read_update_atime Date: Sat, 30 Oct 2010 00:11:50 +0200 Message-ID: <201010300011.51022.edward.shishkin@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: jmoyer@redhat.com, hch@lst.de, esandeen@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Andrew Morton Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:52685 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755031Ab0J2WMg (ORCPT ); Fri, 29 Oct 2010 18:12:36 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: This is similar to the bug found in direct-io not so long ago. Fix up truncation (ssize_t->int). This only matters with >2G reads/writes, which the kernel doesn't permit. Signed-off-by: Edward Shishkin --- fs/ecryptfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.36.orig/fs/ecryptfs/file.c +++ linux-2.6.36/fs/ecryptfs/file.c @@ -48,7 +48,7 @@ static ssize_t ecryptfs_read_update_atim const struct iovec *iov, unsigned long nr_segs, loff_t pos) { - int rc; + ssize_t rc; struct dentry *lower_dentry; struct vfsmount *lower_vfsmount; struct file *file = iocb->ki_filp;