From: Christoph Hellwig <hch@infradead.org>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Mel Gorman <mel@csn.ul.ie>, Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Minchan Kim <minchan.kim@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] writeback: integrated background writeback work
Date: Mon, 1 Nov 2010 11:21:50 -0400 [thread overview]
Message-ID: <20101101152149.GA12741@infradead.org> (raw)
In-Reply-To: <20101101121408.GB9006@localhost>
> +static void _bdi_wakeup_flusher(struct backing_dev_info *bdi)
Remove the leading underscore, please.
> void bdi_start_background_writeback(struct backing_dev_info *bdi)
> {
> - __bdi_start_writeback(bdi, LONG_MAX, true, true);
> + /*
> + * We just wake up the flusher thread. It will perform background
> + * writeback as soon as there is no other work to do.
> + */
> + spin_lock_bh(&bdi->wb_lock);
> + _bdi_wakeup_flusher(bdi);
> + spin_unlock_bh(&bdi->wb_lock);
We probably want a trace point here, too.
Otherwise the patch looks good to me. Thanks for bringing it up again.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-01 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100913123110.372291929@intel.com>
[not found] ` <20100913130149.994322762@intel.com>
[not found] ` <20100914124033.GA4874@quack.suse.cz>
2010-11-01 12:14 ` [PATCH 1/2] writeback: integrated background writeback work Wu Fengguang
2010-11-01 12:22 ` [PATCH 2/2] writeback: stop background/kupdate works from livelocking other works Wu Fengguang
2010-11-01 15:22 ` Christoph Hellwig
2010-11-02 1:57 ` Minchan Kim
2010-11-05 12:15 ` Johannes Weiner
2010-11-01 15:21 ` Christoph Hellwig [this message]
2010-11-01 20:37 ` [PATCH 1/2] writeback: integrated background writeback work Wu Fengguang
2010-11-01 20:39 ` [PATCH 1/2 v2] " Wu Fengguang
2010-11-02 1:55 ` Minchan Kim
2010-11-05 12:01 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101101152149.GA12741@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).