From: Greg KH <greg@kroah.com>
To: Tracey Dent <tdent48227@gmail.com>
Cc: Charles Manning <manningc2@actrix.gen.nz>,
David Daney <ddaney@caviumnetworks.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/29] Staging: Add yaffs2 filesystem
Date: Mon, 1 Nov 2010 13:13:27 -0700 [thread overview]
Message-ID: <20101101201327.GC2049@kroah.com> (raw)
In-Reply-To: <AANLkTi=XmuhYoiJNGATDEtGyxj7FWH2UCN8QgqcRmEN6@mail.gmail.com>
On Mon, Nov 01, 2010 at 03:36:13PM -0400, Tracey Dent wrote:
> On 11/1/10, Charles Manning <manningc2@actrix.gen.nz> wrote:
> > On Tuesday 02 November 2010 08:24:42 David Daney wrote:
> >> On 11/01/2010 12:14 PM, Charles Manning wrote:
> >> > On Tuesday 02 November 2010 07:55:39 David Daney wrote:
> >> >> On 11/01/2010 11:40 AM, Tracey Dent wrote:
> >> >>> The patch sets puts the yaffs2 filesystem in the staging directory.
> >> >>> It is all based on Charles git
> >> >>> tree(http://github.com/cdhmanning/linux-yaffs-integration/).
> >> >>> Everything
> >> >>> is compile tested and it builds.
> >> >>>
> >> >>> This only the inital support and I will be sending more cleanup
> >> >>> patches.
> >> >>>
> >> >>> Greg can you add the patch set into your staging-next tree.
> >> >>> Also, It doesn't affect anything other than itself.
> >> >>>
> >> >>> Thanks,
> >> >>>
> >> >>> Tracey Dent
> >> >>
> >> >> I am confused.
> >> >>
> >> >> Are you and Charles Manning working together on this?
> >> >>
> >> >> Did you write all this code or did Charles? If it was Charles, why are
> >> >> there no From: and Signed-off-by headers for him?
> >> >>
> >> >> Thanks in advance for enlightening us as to what is going on here,
> >> >> David Daney
> >> >
> >> > We are not working together on this, but I do appreciate the effort in
> >> > helping bring to a head what people like/dislike.
> >> >
> >> > I am trying to keep the kernel yaffs consistent with the yaffs.net yaffs
> >> > so that it is easier to add changes from yaffs.net.
> >>
> >> Great. Thanks for clearing things up.
> >>
> >> I will offer my unsolicited opinion:
> >>
> >> Charles has obviously expended great effort on yaffs2. He has a git
> >> repository hosting the code, and has expressed a desire to get the code
> >> fit for merging. For Tracey Dent to come along and hijack the entire
> >> effort, would anger me if I were in Charles' place.
> >
> > I don't see any malicious intent from Tracey, but I do wish to see some
> > recognition for 8+ years of effort :-).
> >
>
> I can resend it with your signed-off-by line instead of mine.
You need to properly credit _who_ did the code in the first place. And
your patches did not do that at all, which is very bad, and rude, and
something that we care deeply about.
Please read the file, Documentation/SubmittingPatches for how to
properly attribute the author of the patch when you send it out.
I'm not going to take this as-is because of this problem, and neither
will any other maintainer. Someone can resend it with the proper author
and signed-off-by stuff and I'll be glad to look at it again then.
thanks,
greg k-h
next prev parent reply other threads:[~2010-11-01 20:12 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 18:40 [PATCH 0/29] Staging: Add yaffs2 filesystem Tracey Dent
2010-11-01 18:40 ` [PATCH 01/29] Staging: Add yaffs2 support Tracey Dent
2010-11-01 18:40 ` [PATCH 02/29] Staging: yaffs2: Add Makefile and Kconfig files Tracey Dent
2010-11-01 18:40 ` [PATCH 03/29] Staging: yaffs2: devextras.h: Add file Tracey Dent
2010-11-01 18:56 ` Pekka Enberg
2010-11-01 20:07 ` Greg KH
2010-11-01 18:40 ` [PATCH 04/29] Staging: yaffs2: moduleconfig.h: " Tracey Dent
2010-11-01 18:57 ` Pekka Enberg
2010-11-01 19:25 ` Tracey Dent
2010-11-01 18:40 ` [PATCH 05/29] Staging: yaffs2: yaffs_allocator: Add files Tracey Dent
2010-11-01 18:58 ` Pekka Enberg
2010-11-01 19:19 ` Charles Manning
2010-11-01 19:23 ` Pekka Enberg
2010-11-01 19:25 ` Pekka Enberg
2010-11-01 18:40 ` [PATCH 06/29] Staging: yaffs2: yaffs_bitmap: " Tracey Dent
2010-11-01 19:01 ` Pekka Enberg
2010-11-01 18:40 ` [PATCH 07/29] Staging: yaffs2: yaffs_checkptrw: " Tracey Dent
2010-11-01 21:09 ` Jesper Juhl
2010-11-01 21:16 ` Jesper Juhl
2010-11-01 18:40 ` [PATCH 08/29] Staging: yaffs2: yaffs_ecc: " Tracey Dent
2010-11-01 19:04 ` Pekka Enberg
2010-11-01 19:50 ` Paul Mundt
2010-11-01 18:40 ` [PATCH 09/29] Staging: yaffs2: yaffs_getblockinfo.h: Add file Tracey Dent
2010-11-01 18:40 ` [PATCH 10/29] Staging: yaffs2: yaffs_guts: Add files Tracey Dent
2010-11-01 19:51 ` Jesper Juhl
2010-11-01 18:40 ` [PATCH 11/29] Staging: yaffs2: yaffs_linux.h: Add file Tracey Dent
2010-11-01 18:41 ` [PATCH 12/29] Staging: yaffs2: yaffs_list.h: add file Tracey Dent
2010-11-01 19:08 ` Pekka Enberg
2010-11-01 18:41 ` [PATCH 13/29] Staging: yaffs2: yaffs_mtdif: Add files Tracey Dent
2010-11-01 18:41 ` [PATCH 14/29] Staging: yaffs2: yaffs_mtdif1: " Tracey Dent
2010-11-01 18:41 ` [PATCH 15/29] Staging: yaffs2: yaffs_mtdif2: " Tracey Dent
2010-11-01 19:05 ` Jesper Juhl
2010-11-01 18:41 ` [PATCH 16/29] Staging: yaffs2: yaffs_nameval: " Tracey Dent
2010-11-01 18:41 ` [PATCH 17/29] Staging: yaffs2: yaffs_nand: " Tracey Dent
2010-11-01 18:41 ` [PATCH 18/29] Staging: yaffs2: yaffs_packedtags1: " Tracey Dent
2010-11-01 18:41 ` [PATCH 19/29] Staging: yaffs2: yaffs_packedtags2: " Tracey Dent
2010-11-01 18:41 ` [PATCH 20/29] Staging: yaffs2: yaffs_qsort.h: Add file Tracey Dent
2010-11-01 19:12 ` Pekka Enberg
2010-11-01 18:41 ` [PATCH 21/29] Staging: yaffs2: yaffs_tagscompact: Add files Tracey Dent
2010-11-01 20:32 ` Jesper Juhl
2010-11-01 18:41 ` [PATCH 22/29] Staging: yaffs2: yaffs_tagsvalidity: " Tracey Dent
2010-11-01 18:41 ` [PATCH 23/29] Staging: yaffs2: yaffs_trace.h: Add file Tracey Dent
2010-11-01 18:41 ` [PATCH 24/29] Staging: yaffs2: yaffs_verify: Add files Tracey Dent
2010-11-01 19:16 ` Jesper Juhl
2010-11-01 19:30 ` Pekka Enberg
2010-11-01 18:41 ` [PATCH 25/29] Staging: yaffs2: yaffs_vfs_glue.c: Add file Tracey Dent
2010-11-01 18:41 ` [PATCH 26/29] Staging: yaffs2: yaffs_yaffs1: Add files Tracey Dent
2010-11-01 18:41 ` [PATCH 27/29] Staging: yaffs2: yaffs_yaffs2: " Tracey Dent
2010-11-01 18:41 ` [PATCH 28/29] Staging: yaffs2: yportenv.h: Add file Tracey Dent
2010-11-01 19:18 ` Pekka Enberg
2010-11-01 18:41 ` [PATCH 29/29] Staging: yaffs2: TODO: Add TODO file Tracey Dent
2010-11-01 19:20 ` Pekka Enberg
2010-11-01 19:38 ` Charles Manning
2010-11-01 18:55 ` [PATCH 0/29] Staging: Add yaffs2 filesystem David Daney
2010-11-01 19:04 ` Greg KH
2010-11-01 19:14 ` Charles Manning
2010-11-01 19:23 ` Tracey Dent
2010-11-01 19:24 ` David Daney
2010-11-01 19:32 ` Charles Manning
2010-11-01 19:36 ` Tracey Dent
2010-11-01 20:13 ` Greg KH [this message]
2010-11-01 20:46 ` Tracey Dent
2010-11-01 21:00 ` David Daney
2010-11-02 1:37 ` Tracey Dent
2010-11-02 3:01 ` Greg KH
2010-11-02 7:34 ` Tracey Dent
2010-11-01 19:34 ` Tracey Dent
2010-11-01 20:16 ` David Daney
2010-11-01 19:06 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101101201327.GC2049@kroah.com \
--to=greg@kroah.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manningc2@actrix.gen.nz \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).