From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [patch 4/6] fs: d_delete change Date: Wed, 10 Nov 2010 09:08:33 +1100 Message-ID: <20101109220833.GG3246@amd> References: <20101109124610.GB11477@amd> <20101109130133.GE11477@amd> <20101109162516.GB6217@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nick Piggin , Al Viro , Linus Torvalds , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:31237 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751002Ab0KIWIi (ORCPT ); Tue, 9 Nov 2010 17:08:38 -0500 Content-Disposition: inline In-Reply-To: <20101109162516.GB6217@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Nov 09, 2010 at 11:25:16AM -0500, Christoph Hellwig wrote: > The patch looks fine to me, and I'm also fine with merging it ASAP. > But the patch subject and commit message are not very descriptive. How is the commit message not descriptive? The first sentence summarises exactly what the change does. The last says why it is required. In the middle are some details.