From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [PATCH 3/5] writeback: stop background/kupdate works from livelocking other works Date: Wed, 10 Nov 2010 11:55:16 +0800 Message-ID: <20101110035516.GA12710@localhost> References: <20101110023500.404859581@intel.com> <20101110024223.847210776@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , Johannes Weiner , Christoph Hellwig , Jan Engelhardt , LKML To: Andrew Morton Return-path: Content-Disposition: inline In-Reply-To: <20101110024223.847210776@intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org Jan, the below comment is also updated, please double check. > > /* > + * Background writeout and kupdate-style writeback may > + * run forever. Stop them if there is other work to do > + * so that e.g. sync can proceed. They'll be restarted > + * after the other works are all done. > + */ > + if ((work->for_background || work->for_kupdate) && > + !list_empty(&wb->bdi->work_list)) > + break; > + > + /* > * For background writeout, stop when we are below the > * background dirty threshold > */ > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org