From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 01/19] quota: protect getfmt call with dqonoff_mutex lock Date: Thu, 11 Nov 2010 08:36:07 -0500 Message-ID: <20101111133607.GA4711@infradead.org> References: <1289477678-5669-1-git-send-email-dmonakhov@openvz.org> <1289477678-5669-2-git-send-email-dmonakhov@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz, hch@infradead.org To: Dmitry Monakhov Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:48998 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756427Ab0KKNgJ (ORCPT ); Thu, 11 Nov 2010 08:36:09 -0500 Content-Disposition: inline In-Reply-To: <1289477678-5669-2-git-send-email-dmonakhov@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Nov 11, 2010 at 03:14:20PM +0300, Dmitry Monakhov wrote: > dqptr_sem hasn't any thing in common with quota files, > quota file load protected with dqonoff_mutex, so we have to use > it for reading fmt info. > > Signed-off-by: Dmitry Monakhov Looks good, but the commit message doesn't mention adding the ->get_fmt method. Reviewed-by: Christoph Hellwig