From: Nick Piggin <npiggin@kernel.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>, Al Viro <viro@ZenIV.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Subject: Patch "fs: use RCU read side protection in d_validate" broken
Date: Mon, 15 Nov 2010 16:11:20 +1100 [thread overview]
Message-ID: <20101115051120.GA4092@amd> (raw)
This patch is totally broken. You can't just dget() a dentry with
nothing but RCU critical section open.
The patch in my tree this is claimed to be split out of, at least
attemptet to do some locking, I don't know why that was stripped
out. But I didn't get that quite right myself at which point I
decided to just forget about it entirely.
Christoph, why did you think such a patch is worth getting merged, btw?
I saw no hint of a justification in your changelog. I mean, in my tree
at least there was a _rationale_ that dcache_lock is going away and this
marginally made the locking simpler. But it doesn't make sense in the
current tree, even if the merged patch was _not_ buggy -- what were you
trying to do, make ncpfs's readdir go really fast?
Breaking things out when they make sense and stand as patches on their
own. That is very important. When they do _not_ make sense on their own,
then that is when they do not make sense to be broken out and merged
ahead of their series.
Linus, I cooked up a fix for it, but decided it's stupid to bother with
any complexity here. Please revert
3825bdb7ed920845961f32f364454bee5f469abb
If I end up wanting it again for dcache series, I can do it with proper
locking and proper justification.
Thanks,
Nick
next reply other threads:[~2010-11-15 5:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 5:11 Nick Piggin [this message]
2010-11-15 5:32 ` Patch "fs: use RCU read side protection in d_validate" broken Nick Piggin
2010-11-15 21:16 ` Christoph Hellwig
2010-11-15 23:06 ` Nick Piggin
2010-11-15 21:09 ` Christoph Hellwig
2010-11-15 22:51 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101115051120.GA4092@amd \
--to=npiggin@kernel.dk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).