From: Christoph Hellwig <hch@infradead.org>
To: Feng Tang <feng.tang@intel.com>
Cc: "Wu, Fengguang" <fengguang.wu@intel.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] jbd2: avoid the concurrent data writeback
Date: Mon, 15 Nov 2010 06:27:32 -0500 [thread overview]
Message-ID: <20101115112732.GA15953@infradead.org> (raw)
In-Reply-To: <20101115175943.490d3469@feng-i7>
On Mon, Nov 15, 2010 at 05:59:43PM +0800, Feng Tang wrote:
> + *
> + * Sometimes when this get called, the host inode may be under data
> + * syncing initiated by flush thread(especially for a large file), and
> + * in such situation, we should skip this path of writeback
> */
> static int journal_submit_inode_data_buffers(struct address_space *mapping)
> {
> @@ -181,6 +185,13 @@ static int journal_submit_inode_data_buffers(struct address_space *mapping)
> .range_end = i_size_read(mapping->host),
> };
>
> + spin_lock(&inode_lock);
> + if (mapping->host->i_state & I_SYNC) {
> + spin_unlock(&inode_lock);
> + return 0;
> + }
> + spin_unlock(&inode_lock);
> +
inode_lock is not exported to modules, and that's for a pretty good
reason. I think you want to change this code at a higher level to not
compete with the flusher threads at all.
next prev parent reply other threads:[~2010-11-15 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1289827533-2576-1-git-send-email-feng.tang@intel.com>
2010-11-15 5:54 ` [PATCH] jbd2: avoid the concurrent data writeback Wu Fengguang
2010-11-15 9:59 ` Feng Tang
2010-11-15 11:27 ` Christoph Hellwig [this message]
2010-11-16 8:13 ` Feng Tang
2010-11-16 12:13 ` Jan Kara
2010-11-17 1:36 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101115112732.GA15953@infradead.org \
--to=hch@infradead.org \
--cc=feng.tang@intel.com \
--cc=fengguang.wu@intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).