From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [patch] fs: fix d_validate
Date: Tue, 16 Nov 2010 17:28:17 +0100
Message-ID: <20101116162817.GA2168@lst.de>
References: <20101116062319.GA3242@amd> <20101116102045.GA22329@lst.de> <20101116102533.GA4139@amd>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@lst.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
	petr@vandrovec.name
To: Nick Piggin <npiggin@kernel.dk>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.210]:56818 "EHLO verein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754502Ab0KPQ2z (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 16 Nov 2010 11:28:55 -0500
Content-Disposition: inline
In-Reply-To: <20101116102533.GA4139@amd>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Nov 16, 2010 at 09:25:33PM +1100, Nick Piggin wrote:
> Right, I depreated it, making it an easy backport. Your next patch
> and then removing it completely would be the next step.

I don't see much of a point in keeping it.  What your new version of
d_validate does is exactly what the two only callers do as a fallback.
Keeping it like that just means we search through d_subdirs another
time when the lookup fails.  No need to keep this beats around longer
than nessecary.