From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Piggin <npiggin@kernel.dk>
Subject: Re: [patch] fs: fix d_validate
Date: Wed, 17 Nov 2010 14:51:57 +1100
Message-ID: <20101117035157.GB3302@amd>
References: <20101116062319.GA3242@amd>
 <20101116102045.GA22329@lst.de>
 <20101116102533.GA4139@amd>
 <20101116162817.GA2168@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Nick Piggin <npiggin@kernel.dk>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
	petr@vandrovec.name
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:60049 "EHLO
	ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751072Ab0KQDwA (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 16 Nov 2010 22:52:00 -0500
Content-Disposition: inline
In-Reply-To: <20101116162817.GA2168@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Nov 16, 2010 at 05:28:17PM +0100, Christoph Hellwig wrote:
> On Tue, Nov 16, 2010 at 09:25:33PM +1100, Nick Piggin wrote:
> > Right, I depreated it, making it an easy backport. Your next patch
> > and then removing it completely would be the next step.
> 
> I don't see much of a point in keeping it.  What your new version of
> d_validate does is exactly what the two only callers do as a fallback.
> Keeping it like that just means we search through d_subdirs another
> time when the lookup fails.  No need to keep this beats around longer
> than nessecary.

It's really no problem to get my bug fixes merged, and keep the exported
symbol around on a deprecation schedule. It doesn't need to be held up by
Patches to rip the dir cache out of the filesystems.