From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: [PATCH 04/13] writeback: prevent duplicate balance_dirty_pages_ratelimited() calls Date: Wed, 17 Nov 2010 11:58:25 +0800 Message-ID: <20101117035905.873681033@intel.com> Cc: Theodore Ts'o , Wu Fengguang To: Andrew Morton Return-path: CC: Dave Chinner CC: Jan Kara CC: Peter Zijlstra CC: Mel Gorman CC: Rik van Riel CC: KOSAKI Motohiro CC: Chris Mason CC: Christoph Hellwig Cc: linux-mm Cc: Cc: LKML Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org Andrew, References: <20101117035821.000579293@intel.com> Content-Disposition: inline; filename=writeback-fix-duplicate-bdp-calls.patch When dd in 512bytes, balance_dirty_pages_ratelimited() used to be called 8 times for the same page, even if the page is only dirtied once. Fix it with a (slightly racy) PageDirty() test. Signed-off-by: Wu Fengguang --- mm/filemap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- linux-next.orig/mm/filemap.c 2010-11-16 22:20:08.000000000 +0800 +++ linux-next/mm/filemap.c 2010-11-16 22:45:05.000000000 +0800 @@ -2258,6 +2258,7 @@ static ssize_t generic_perform_write(str long status = 0; ssize_t written = 0; unsigned int flags = 0; + unsigned int dirty; /* * Copies from kernel address space cannot fail (NFSD is a big user). @@ -2306,6 +2307,7 @@ again: pagefault_enable(); flush_dcache_page(page); + dirty = PageDirty(page); mark_page_accessed(page); status = a_ops->write_end(file, mapping, pos, bytes, copied, page, fsdata); @@ -2332,7 +2334,8 @@ again: pos += copied; written += copied; - balance_dirty_pages_ratelimited(mapping); + if (!dirty) + balance_dirty_pages_ratelimited(mapping); } while (iov_iter_count(i)); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org