From: Christoph Hellwig <hch@lst.de>
To: Nick Piggin <npiggin@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 10/11] hfsplus: optimize fsync
Date: Thu, 18 Nov 2010 15:16:57 +0100 [thread overview]
Message-ID: <20101118141657.GA16690@lst.de> (raw)
In-Reply-To: <AANLkTi=EW9_Yp44jcNjv=zcGk1jCchbQ=fK2XvZ0h8WU@mail.gmail.com>
On Fri, Nov 19, 2010 at 01:13:55AM +1100, Nick Piggin wrote:
> >> Anyway, what if writeback noticed pagecache was cleaned at this point, and then
> >> clears I_DIRTY bits from inode before you test it above? Won't that leave your
> >> metadata not on disk?
>
> I'm not sure if you answered this, though. Can't background writeout go through
> and clear the I_DIRTY_* bits on your inode, so that a subsequent fsync will skip
> required writeout because i_state is clean, but your private dirty
> bits are still set?
>
> That was my (poorly worded) concern.
Good point - we should just skip the sync_inode_metadata for that case.
Which already is a no-op if no dirty bits are set, so just removing the
I_DIRTY check probably is the best thing we can do here.
next prev parent reply other threads:[~2010-11-18 14:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 22:21 hfsplus patch review Christoph Hellwig
2010-11-17 22:21 ` [PATCH 1/11] hfsplus: silence a few debug printks Christoph Hellwig
2010-11-17 22:21 ` [PATCH 2/11] hfsplus: always use hfsplus_sync_fs to write the volume header Christoph Hellwig
2010-11-17 22:22 ` [PATCH 3/11] hfsplus: use raw bio access for the volume headers Christoph Hellwig
2010-11-17 22:22 ` [PATCH 4/11] hfsplus: use raw bio access for partition tables Christoph Hellwig
2010-11-17 22:22 ` [PATCH 5/11] hfsplus: make sure sync writes out all metadata Christoph Hellwig
2010-11-17 22:22 ` [PATCH 6/11] hfsplus: avoid useless work in hfsplus_sync_fs Christoph Hellwig
2010-11-17 22:22 ` [PATCH 7/11] hfsplus: simplify fsync Christoph Hellwig
2010-11-17 22:22 ` [PATCH 8/11] hfsplus: write up fsync for directories Christoph Hellwig
2010-11-17 22:23 ` [PATCH 9/11] hfsplus: split up inode flags Christoph Hellwig
2010-11-17 22:23 ` [PATCH 10/11] hfsplus: optimize fsync Christoph Hellwig
2010-11-18 6:40 ` Nick Piggin
2010-11-18 13:50 ` Christoph Hellwig
2010-11-18 14:13 ` Nick Piggin
2010-11-18 14:16 ` Christoph Hellwig [this message]
2010-11-22 13:03 ` Nick Piggin
2010-11-22 13:18 ` Nick Piggin
2010-11-22 13:29 ` Christoph Hellwig
2010-11-22 11:35 ` [PATCH v2] " Christoph Hellwig
2010-11-17 22:23 ` [PATCH 11/11] hfsplus: flush disk caches in sync and fsync Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118141657.GA16690@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).