From: Christoph Hellwig <hch@infradead.org>
To: Nick Piggin <npiggin@kernel.dk>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [patch 1/4] fs: mark_inode_dirty barrier fix
Date: Mon, 22 Nov 2010 08:16:01 -0500 [thread overview]
Message-ID: <20101122131601.GA25321@infradead.org> (raw)
In-Reply-To: <20101122130507.GC12716@amd>
On Tue, Nov 23, 2010 at 12:05:07AM +1100, Nick Piggin wrote:
>
> fs: mark_inode_dirty barrier fix
>
> Filesystems appear to be using ->dirty_inode, expecting that the dirtying
> operating is done and visible to all CPUs (eg. setting private inode dirty
> bits, without any barriers themselves). So release the dirty "critical
> section" with a barrier before calling ->dirty_inode.
>
> Cost is not significantly changed, because we're just moving the barrier.
> Those filesystems that do use ->dirty_inode should have to care slightly
> less about barriers, which is a good thing.
>
> Signed-off-by: Nick Piggin <npiggin@kernel.dk>
Looks good to me. I can't see any reason to have a barrier after
->dirty_inode.
prev parent reply other threads:[~2010-11-22 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 13:05 [patch 1/4] fs: mark_inode_dirty barrier fix Nick Piggin
2010-11-22 13:06 ` [patch 2/4] fs: fsync inode dirty race fix Nick Piggin
2010-11-22 13:23 ` Christoph Hellwig
2010-11-22 13:43 ` Nick Piggin
2010-11-22 13:07 ` [patch 3/4] fs: introduce inode dirty state helpers Nick Piggin
2010-11-22 13:25 ` Christoph Hellwig
2010-11-22 13:44 ` Nick Piggin
2010-11-22 13:09 ` [patch 4/4] ext2: inode sync fixes Nick Piggin
2010-11-22 13:16 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122131601.GA25321@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).