From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [patch 3/4] fs: introduce inode dirty state helpers Date: Mon, 22 Nov 2010 08:25:53 -0500 Message-ID: <20101122132552.GC25321@infradead.org> References: <20101122130507.GC12716@amd> <20101122130733.GE12716@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Nick Piggin Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:38048 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753587Ab0KVNZx (ORCPT ); Mon, 22 Nov 2010 08:25:53 -0500 Content-Disposition: inline In-Reply-To: <20101122130733.GE12716@amd> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Nov 23, 2010 at 12:07:33AM +1100, Nick Piggin wrote: > Inode dirty state cannot be securely tested without participating properly > in the inode writeback protocol. Some filesystems need to check this state, > so break out the code into helpers and make them available. > > This could also be used to reduce strange interactions between background > writeback and fsync. Currently if we fsync a single page in a file, the > entire file gets requeued to the back of the background IO list, even if > it is due for writeout and has a large number of pages. That's left for > a later time. If you want filesystems to use the helpers they need to be exported, and good kerneldoc comments so that filesystem writers know what they need to do.