From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 01/19] quota: protect getfmt call with dqonoff_mutex lock Date: Mon, 22 Nov 2010 20:35:02 +0100 Message-ID: <20101122193502.GC6141@quack.suse.cz> References: <1289477678-5669-1-git-send-email-dmonakhov@openvz.org> <1289477678-5669-2-git-send-email-dmonakhov@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz, hch@infradead.org To: Dmitry Monakhov Return-path: Received: from cantor.suse.de ([195.135.220.2]:55724 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757186Ab0KVTfF (ORCPT ); Mon, 22 Nov 2010 14:35:05 -0500 Content-Disposition: inline In-Reply-To: <1289477678-5669-2-git-send-email-dmonakhov@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu 11-11-10 15:14:20, Dmitry Monakhov wrote: > dqptr_sem hasn't any thing in common with quota files, > quota file load protected with dqonoff_mutex, so we have to use > it for reading fmt info. You missed ext2 and jfs from the conversion. Also you should mention that you introduce new ->get_fmt call. Other than that just one nitpick: > diff --git a/include/linux/quota.h b/include/linux/quota.h > index 9a85412..2767e4c 100644 > --- a/include/linux/quota.h > +++ b/include/linux/quota.h > @@ -331,6 +331,7 @@ struct quotactl_ops { > int (*quota_off)(struct super_block *, int); > int (*quota_sync)(struct super_block *, int, int); > int (*get_info)(struct super_block *, int, struct if_dqinfo *); > + int (*get_fmt)(struct super_block*, int, unsigned int*); ^ space before * Honza -- Jan Kara SUSE Labs, CR