From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: linux-fsdevel@vger.kernel.org, bug-bash@gnu.org
Subject: bash: Correct usage of F_SETFD
Date: Mon, 22 Nov 2010 12:16:20 -0800 [thread overview]
Message-ID: <20101122201620.GA16687@us.ibm.com> (raw)
include/filecntl.h in bash-4.1 has following:
#define SET_CLOSE_ON_EXEC(fd) (fcntl ((fd), F_SETFD, FD_CLOEXEC))
Is that really the correct/intended usage of F_SETFD ?
If kernel ever adds a new flag to the fd, this would end up clearing the
other new flag right ?
Shouldn't bash use F_GETFD to get the current flags and set/clear just
the FD_CLOEXEC bit ?
Sukadev
next reply other threads:[~2010-11-22 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 20:16 Sukadev Bhattiprolu [this message]
2010-11-22 22:16 ` bash: Correct usage of F_SETFD Chet Ramey
2010-11-22 22:27 ` Eric Blake
2010-11-23 0:04 ` Sukadev Bhattiprolu
2010-11-23 14:42 ` Matthew Wilcox
2010-11-23 14:51 ` Eric Blake
2010-11-23 17:51 ` Sukadev Bhattiprolu
2010-11-24 1:17 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122201620.GA16687@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=bug-bash@gnu.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).