From: Andrew Morton <akpm@linux-foundation.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Chris Mason <chris.mason@oracle.com>,
Nick Piggin <npiggin@kernel.dk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
Jan Kara <jack@suse.cz>, Eric Sandeen <sandeen@redhat.com>,
"Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [patch] fs: fix deadlocks in writeback_if_idle
Date: Thu, 25 Nov 2010 12:30:01 -0800 [thread overview]
Message-ID: <20101125123001.9bc75815.akpm@linux-foundation.org> (raw)
In-Reply-To: <4CEE2F5E.4070608@panasas.com>
On Thu, 25 Nov 2010 11:41:50 +0200 Boaz Harrosh <bharrosh@panasas.com> wrote:
> On 11/25/2010 12:47 AM, Andrew Morton wrote:
> > On Tue, 23 Nov 2010 07:34:07 -0500
> > Chris Mason <chris.mason@oracle.com> wrote:
> >
> >> For btrfs there's only one bdi per SB, but for most everyone else a disk
> >> with a bunch of partitions is going to have multiple filesystems on the
> >> same bdi.
> >
> > um, please explain why that wasn't idiotic? The BDI is a
> > representation of a backing device and it's *supposed* to provide
> > visibility into what's happening against other partitions on the same
> > device. Creating a BDI per SB (it didn't even occur to me to think
> > that a filesystem was even able to do this) breaks that.
> >
>
> In btrfs an SB my span multiple partitions. How else can it be solved?
Associate a number of bdi's with the superblock. If necessary, convert
core kernel to operate on groups of BDI's. Which shouldn't be too hard
given that core kernel already does this, for MD.
ie: something which faithfully models what is actually going on, rather
than simply bending reality.
next prev parent reply other threads:[~2010-11-25 20:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 10:02 [patch] fs: fix deadlocks in writeback_if_idle Nick Piggin
2010-11-23 10:11 ` Nick Piggin
2010-11-23 13:18 ` Jan Kara
2010-11-25 3:52 ` Nick Piggin
2010-11-23 10:26 ` Boaz Harrosh
2010-11-23 10:54 ` Nick Piggin
2010-11-23 12:00 ` Boaz Harrosh
2010-11-23 12:34 ` Chris Mason
2010-11-23 12:52 ` Nick Piggin
2010-11-23 18:58 ` Chris Mason
2010-11-24 1:03 ` Nick Piggin
2010-11-24 13:10 ` Jan Kara
2010-11-25 3:53 ` Nick Piggin
2010-11-29 22:26 ` Andrew Morton
2010-11-30 0:01 ` Nick Piggin
2010-12-16 3:12 ` Nick Piggin
2010-11-24 22:51 ` Andrew Morton
2010-11-25 4:07 ` Nick Piggin
2010-11-24 22:47 ` Andrew Morton
2010-11-25 9:41 ` Boaz Harrosh
2010-11-25 20:30 ` Andrew Morton [this message]
2010-11-30 0:50 ` Chris Mason
2010-11-23 12:54 ` Dmitry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101125123001.9bc75815.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bharrosh@panasas.com \
--cc=chris.mason@oracle.com \
--cc=jack@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).