From: Morten Hustveit <mortehu@ping.uio.no>
To: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Andreas Dilger <adilger.kernel@dilger.ca>
Subject: [PATCH v2] fcntl: Add the F_READAHEAD command
Date: Fri, 26 Nov 2010 01:36:13 +0100 [thread overview]
Message-ID: <20101126003613.GA2026@ping.uio.no> (raw)
In-Reply-To: <DEAF94DC-08D0-42D2-A6E9-62B1B9C39D40@dilger.ca>
Allow userland applications to control the read-ahead per file descriptor.
For example, this interface can be used to adjust read sizes in applications
using sendfile() to serve many streams from disk.
The implementation is based on sys_readahead() and sys_fadvise64().
The same interface was added to FreeBSD in 2009.
Signed-off-by: Morten Hustveit <mortehu@ping.uio.no>
---
Changes for v2:
- Renamed "arg" to "ra_bytes". "ra_bytes" was used instead of
"readahead_bytes" to keep lines at less than 80 columns, and to be
consistent with "ra_pages".
diff --git a/fs/fcntl.c b/fs/fcntl.c
index ecc8b39..9d78274 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -340,6 +340,31 @@ static int f_getown_ex(struct file *filp, unsigned long arg)
return ret;
}
+static int f_readahead(struct file *filp, unsigned long ra_bytes)
+{
+ struct address_space *mapping;
+
+ mapping = filp->f_mapping;
+ if (!mapping || !mapping->a_ops || !mapping->a_ops->readpage)
+ return -EINVAL;
+
+ if (mapping->a_ops->get_xip_mem)
+ return 0;
+
+ if (ra_bytes) {
+ filp->f_ra.ra_pages = (ra_bytes + PAGE_SIZE - 1) >> PAGE_SHIFT;
+ spin_lock(&filp->f_lock);
+ filp->f_mode &= ~FMODE_RANDOM;
+ spin_unlock(&filp->f_lock);
+ } else {
+ spin_lock(&filp->f_lock);
+ filp->f_mode |= FMODE_RANDOM;
+ spin_unlock(&filp->f_lock);
+ }
+
+ return 0;
+}
+
static long do_fcntl(int fd, unsigned int cmd, unsigned long arg,
struct file *filp)
{
@@ -420,6 +445,9 @@ static long do_fcntl(int fd, unsigned int cmd, unsigned long arg,
case F_GETPIPE_SZ:
err = pipe_fcntl(filp, cmd, arg);
break;
+ case F_READAHEAD:
+ err = f_readahead(filp, arg);
+ break;
default:
break;
}
diff --git a/include/linux/fcntl.h b/include/linux/fcntl.h
index afc00af..69d8e4d 100644
--- a/include/linux/fcntl.h
+++ b/include/linux/fcntl.h
@@ -28,6 +28,11 @@
#define F_GETPIPE_SZ (F_LINUX_SPECIFIC_BASE + 8)
/*
+ * Set read-ahead buffer size
+ */
+#define F_READAHEAD (F_LINUX_SPECIFIC_BASE + 9)
+
+/*
* Types of directory notifications that may be requested.
*/
#define DN_ACCESS 0x00000001 /* File accessed */
prev parent reply other threads:[~2010-11-26 0:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 9:54 [PATCH] fcntl: Add the F_READAHEAD command Morten Hustveit
2010-11-25 18:08 ` Andreas Dilger
2010-11-26 0:36 ` Morten Hustveit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101126003613.GA2026@ping.uio.no \
--to=mortehu@ping.uio.no \
--cc=adilger.kernel@dilger.ca \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).