From: Christoph Hellwig <hch@infradead.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] vfs: Add a trace point in the mark_inode_dirty function
Date: Sun, 28 Nov 2010 12:52:56 -0500 [thread overview]
Message-ID: <20101128175256.GA30783@infradead.org> (raw)
In-Reply-To: <20101126125619.78b2862d@infradead.org>
Looks generally good to me.
Two sugestions:
- also trace the flags value and decode it using __print_flags in the
output
- use a dev_t instead of the split major/minor to follow the way the
block layer, writeback and xfs tracepoints track the block device.
Seems like this was copied from the recent conversion of ext4 away
from it's braindead string printing, which didn't follow the existing
way either.
next prev parent reply other threads:[~2010-11-28 17:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 20:56 [PATCH] vfs: Add a trace point in the mark_inode_dirty function Arjan van de Ven
2010-11-28 17:52 ` Christoph Hellwig [this message]
2010-11-28 18:43 ` Arjan van de Ven
2010-11-29 1:41 ` KOSAKI Motohiro
2010-11-29 4:54 ` Arjan van de Ven
2010-11-29 5:15 ` KOSAKI Motohiro
2010-11-29 14:21 ` Steven Rostedt
2010-11-29 14:41 ` Mathieu Desnoyers
2010-11-29 16:31 ` Steven Rostedt
2010-11-30 0:37 ` KOSAKI Motohiro
2010-11-29 3:53 ` Nick Piggin
-- strict thread matches above, loose matches on Subject: below --
2009-10-26 5:53 Arjan van de Ven
2009-10-26 6:03 ` Andrew Morton
2009-10-26 6:55 ` Arjan van de Ven
2009-10-27 16:01 ` Jason Baron
2009-11-11 2:01 ` Wu Fengguang
2009-11-11 6:34 ` Arjan van de Ven
2009-11-11 6:40 ` Wu Fengguang
2009-11-11 7:42 ` Jeff Garzik
2009-11-11 7:45 ` Ingo Molnar
2009-11-11 7:56 ` Jeff Garzik
2009-11-11 11:15 ` Ingo Molnar
2009-11-11 17:27 ` Kok, Auke
2009-11-11 18:29 ` Theodore Tso
2009-11-11 18:56 ` Ingo Molnar
2009-11-12 2:15 ` Arjan van de Ven
2009-11-11 16:19 ` Arjan van de Ven
2009-11-11 23:10 ` Frank Ch. Eigler
2009-11-11 23:37 ` Kok, Auke
2009-11-12 7:22 ` Ingo Molnar
2009-11-20 10:43 ` Christoph Hellwig
2009-11-20 10:51 ` Ingo Molnar
2009-11-20 14:45 ` Arjan van de Ven
2009-11-20 16:05 ` Jamie Lokier
2009-11-20 16:45 ` Arjan van de Ven
2009-11-11 2:33 ` Li Zefan
2009-11-15 19:00 ` Arjan van de Ven
2009-11-16 0:56 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101128175256.GA30783@infradead.org \
--to=hch@infradead.org \
--cc=arjan@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).