From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] vfs: Add a trace point in the mark_inode_dirty function
Date: Sun, 28 Nov 2010 12:52:56 -0500
Message-ID: <20101128175256.GA30783@infradead.org>
References: <20101126125619.78b2862d@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Al Viro <viro@ZenIV.linux.org.uk>
To: Arjan van de Ven <arjan@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:46379 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753795Ab0K1Rw6 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sun, 28 Nov 2010 12:52:58 -0500
Content-Disposition: inline
In-Reply-To: <20101126125619.78b2862d@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Looks generally good to me.

Two sugestions:

 - also trace the flags value and decode it using __print_flags in the
   output
 - use a dev_t instead of the split major/minor to follow the way the
   block layer, writeback and xfs tracepoints track the block device.
   Seems like this was copied from the recent conversion of ext4 away
   from it's braindead string printing, which didn't follow the existing
   way either.