From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch 4/7] fs: preserve inode dirty bits on failed metadata
 writeback
Date: Mon, 29 Nov 2010 09:59:37 -0500
Message-ID: <20101129145936.GC26076@infradead.org>
References: <20101123140610.292941494@kernel.dk>
 <20101123140707.922192750@kernel.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: npiggin@kernel.dk
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20101123140707.922192750@kernel.dk>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, Nov 24, 2010 at 01:06:14AM +1100, npiggin@kernel.dk wrote:
> Otherwise we think the inode is clean even if syncing failed.

The patch itself looks fine, but I'm not sure it's enough.  If we do
an synchronous writeout it could fail long after ->write_inode
has returned.