From: Nick Piggin <npiggin@kernel.dk>
To: sedat.dilek@gmail.com
Cc: Nick Piggin <npiggin@kernel.dk>, linux-fsdevel@vger.kernel.org
Subject: Re: vfs-scale-working: NULL dereference in vfat_cmpi()
Date: Sat, 4 Dec 2010 04:27:49 +1100 [thread overview]
Message-ID: <20101203172749.GA11943@amd> (raw)
In-Reply-To: <AANLkTimCNB-PEF6CbW1WrM4KJMALvS0v+G6zkYqrnbOK@mail.gmail.com>
On Wed, Dec 01, 2010 at 05:32:39PM +0100, Sedat Dilek wrote:
> Hi Nick,
>
> while playing with the vfs-scale-working I discovered besides the
> problem in [1] also a NULL dereference in vfat_cmpi() (see attached
> screenshot).
>
> This happened when I wanted to copy pics stored on a 256M SDcard
> (plugged into a Transcend USB2-SDcard-adapter for faster reading data)
> to my local harddisk.
>
> The system was frozen - again a brutal cold start.
>
> Hope this helps you finding the bug.
Ah it does, thanks. It tried to dereference NULL inode from negative
dentry. First line of vat_cmpi should be parent->d_sb rather than
inode->i_sb.
I think I'll want to tweak the d_compare API change not to pass the
inode in, to avoid this possibility.
Thanks,
Nick
parent reply other threads:[~2010-12-03 17:27 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <AANLkTimCNB-PEF6CbW1WrM4KJMALvS0v+G6zkYqrnbOK@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101203172749.GA11943@amd \
--to=npiggin@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).