From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: [PATCH 17/47] writeback: do uninterruptible sleep in balance_dirty_pages() Date: Mon, 13 Dec 2010 14:43:06 +0800 Message-ID: <20101213064839.047784036@intel.com> References: <20101213064249.648862451@intel.com> Cc: Jan Kara , Wu Fengguang To: Andrew Morton Return-path: CC: Christoph Hellwig CC: Trond Myklebust CC: Dave Chinner CC: Theodore Ts'o CC: Chris Mason CC: Peter Zijlstra CC: Mel Gorman CC: Rik van Riel CC: KOSAKI Motohiro CC: Greg Thelen CC: Minchan Kim Cc: linux-mm Cc: Cc: LKML Content-Disposition: inline; filename=writeback-pause-TASK_UNINTERRUPTIBLE.patch Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org Comments from Andrew Morton: Using TASK_INTERRUPTIBLE in balance_dirty_pages() seems wrong. If it's going to do that then it must break out if signal_pending(), otherwise it's pretty much guaranteed to degenerate into a busywait loop. Plus we *do* want these processes to appear in D state and to contribute to load average. So it should be TASK_UNINTERRUPTIBLE. Signed-off-by: Wu Fengguang --- mm/page-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next.orig/mm/page-writeback.c 2010-12-08 22:44:26.000000000 +0800 +++ linux-next/mm/page-writeback.c 2010-12-08 22:44:27.000000000 +0800 @@ -673,7 +673,7 @@ pause: pages_dirtied, pause); bdi_update_write_bandwidth(bdi, &bw_time, &bw_written); - __set_current_state(TASK_INTERRUPTIBLE); + __set_current_state(TASK_UNINTERRUPTIBLE); io_schedule_timeout(pause); bdi_update_write_bandwidth(bdi, &bw_time, &bw_written); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org