From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: [PATCH 19/47] writeback: fix increasement of nr_dirtied_pause Date: Mon, 13 Dec 2010 14:43:08 +0800 Message-ID: <20101213064839.291896969@intel.com> References: <20101213064249.648862451@intel.com> Cc: Jan Kara , Wu Fengguang To: Andrew Morton Return-path: CC: Christoph Hellwig CC: Trond Myklebust CC: Dave Chinner CC: Theodore Ts'o CC: Chris Mason CC: Peter Zijlstra CC: Mel Gorman CC: Rik van Riel CC: KOSAKI Motohiro CC: Greg Thelen CC: Minchan Kim Cc: linux-mm Cc: Cc: LKML Content-Disposition: inline; filename=writeback-fix-increase-nr_dirtied_pause.patch Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org Fix a bug that current->nr_dirtied_pause += current->nr_dirtied_pause >> 5; does not effectively increase nr_dirtied_pause when it's less than 32. Thus nr_dirtied_pause may never grow up. Signed-off-by: Wu Fengguang --- mm/page-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next.orig/mm/page-writeback.c 2010-12-08 22:44:27.000000000 +0800 +++ linux-next/mm/page-writeback.c 2010-12-08 22:44:28.000000000 +0800 @@ -700,7 +700,7 @@ pause: if (pause == 0 && nr_dirty < background_thresh) current->nr_dirtied_pause = ratelimit_pages(bdi); else if (pause == 1) - current->nr_dirtied_pause += current->nr_dirtied_pause >> 5; + current->nr_dirtied_pause += current->nr_dirtied_pause / 32 + 1; else if (pause >= HZ/10) /* * when repeated, writing 1 page per 100ms on slow devices, -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org