From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: [PATCH 43/47] nfs: dont change wbc->nr_to_write in write_inode() Date: Mon, 13 Dec 2010 14:43:32 +0800 Message-ID: <20101213064842.310150037@intel.com> References: <20101213064249.648862451@intel.com> Cc: Jan Kara , Trond Myklebust , Wu Fengguang To: Andrew Morton Return-path: CC: Christoph Hellwig CC: Dave Chinner CC: Theodore Ts'o CC: Chris Mason CC: Peter Zijlstra CC: Mel Gorman CC: Rik van Riel CC: KOSAKI Motohiro CC: Greg Thelen CC: Minchan Kim Cc: linux-mm Cc: Cc: LKML Content-Disposition: inline; filename=writeback-nfs-commit-remove-nr_to_write.patch Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org It's introduced in commit 420e3646 ("NFS: Reduce the number of unnecessary COMMIT calls") and seems not necessary. CC: Trond Myklebust Signed-off-by: Wu Fengguang --- fs/nfs/write.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) --- linux-next.orig/fs/nfs/write.c 2010-12-09 12:20:20.000000000 +0800 +++ linux-next/fs/nfs/write.c 2010-12-09 12:20:30.000000000 +0800 @@ -1557,15 +1557,8 @@ static int nfs_commit_unstable_pages(str } ret = nfs_commit_inode(inode, flags); - if (ret >= 0) { - if (wbc->sync_mode == WB_SYNC_NONE) { - if (ret < wbc->nr_to_write) - wbc->nr_to_write -= ret; - else - wbc->nr_to_write = 0; - } + if (ret >= 0) return 0; - } out_mark_dirty: __mark_inode_dirty(inode, I_DIRTY_DATASYNC); return ret; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org