* [PATCH 1/1] hfsplus: fix an artifact in ioctl flag checking
@ 2010-12-16 12:44 Anton Salikhmetov
2010-12-16 17:12 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Anton Salikhmetov @ 2010-12-16 12:44 UTC (permalink / raw)
To: linux-fsdevel, hch
Fix a flag checking artifact in hfsplus_ioctl_getflags() routine
found while doing clean-up against assignments inside `if's.
Signed-off-by: Anton Salikhmetov <alexo@tuxera.com>
---
fs/hfsplus/ioctl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/hfsplus/ioctl.c b/fs/hfsplus/ioctl.c
index 40a85a3..4caa3dc 100644
--- a/fs/hfsplus/ioctl.c
+++ b/fs/hfsplus/ioctl.c
@@ -28,7 +28,7 @@ static int hfsplus_ioctl_getflags(struct file *file, int __user *user_flags)
if (inode->i_flags & S_IMMUTABLE)
flags |= FS_IMMUTABLE_FL;
- if (inode->i_flags |= S_APPEND)
+ if (inode->i_flags & S_APPEND)
flags |= FS_APPEND_FL;
if (hip->userflags & HFSPLUS_FLG_NODUMP)
flags |= FS_NODUMP_FL;
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] hfsplus: fix an artifact in ioctl flag checking
2010-12-16 12:44 [PATCH 1/1] hfsplus: fix an artifact in ioctl flag checking Anton Salikhmetov
@ 2010-12-16 17:12 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2010-12-16 17:12 UTC (permalink / raw)
To: Anton Salikhmetov; +Cc: linux-fsdevel, hch
On Thu, Dec 16, 2010 at 02:44:51PM +0200, Anton Salikhmetov wrote:
> Fix a flag checking artifact in hfsplus_ioctl_getflags() routine
> found while doing clean-up against assignments inside `if's.
>
> Signed-off-by: Anton Salikhmetov <alexo@tuxera.com>
Thanks, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-16 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-16 12:44 [PATCH 1/1] hfsplus: fix an artifact in ioctl flag checking Anton Salikhmetov
2010-12-16 17:12 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).