From: Christoph Hellwig <hch@lst.de>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Anton Salikhmetov <alexo@tuxera.com>,
hch@tuxera.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 5/5] hfsplus: assignments inside `if' condition clean-up
Date: Thu, 16 Dec 2010 18:13:31 +0100 [thread overview]
Message-ID: <20101216171331.GB15245@lst.de> (raw)
In-Reply-To: <193249C4-3F7B-4E3C-AACD-596B86983C45@dilger.ca>
On Thu, Dec 16, 2010 at 10:09:38AM -0700, Andreas Dilger wrote:
> On 2010-12-16, at 09:08, Anton Salikhmetov wrote:
> > Make assignments outside `if' conditions for unicode.c module
> > where the checkpatch.pl script reported this coding style error.
>
> Patches to do _only_ style cleanups are generally frowned upon. However, assignments in conditionals are potentially bug-inducing (either now, or if the code is modified in the future when the developer sees "==" when it actually has "="), so this patch is probably worthwhile.
I'm not a big fan of pure cleanups either, but I'll suck in the whole
series in the hope that this means hfsplus is done as far as cleanups
are concerned from now on.
prev parent reply other threads:[~2010-12-16 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 16:08 [PATCH 0/5] hfsplus: clean-up based on checkpatch.pl Anton Salikhmetov
2010-12-16 16:08 ` [PATCH 1/5] hfsplus: over 80 character lines clean-up Anton Salikhmetov
2010-12-16 16:08 ` [PATCH 2/5] hfsplus: C99 comments clean-up Anton Salikhmetov
2010-12-16 16:08 ` [PATCH 3/5] hfsplus: spaces/indentation clean-up Anton Salikhmetov
2010-12-16 16:08 ` [PATCH 4/5] hfsplus: %L-to-%ll, macro correction, and remove unneeded braces Anton Salikhmetov
2010-12-16 16:08 ` [PATCH 5/5] hfsplus: assignments inside `if' condition clean-up Anton Salikhmetov
2010-12-16 17:09 ` Andreas Dilger
2010-12-16 17:13 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216171331.GB15245@lst.de \
--to=hch@lst.de \
--cc=adilger@dilger.ca \
--cc=alexo@tuxera.com \
--cc=hch@tuxera.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).